netdev - Re: [PATCH v4 net-next 3/6] ila: Call library function alloc_bucket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201712170446.COuJMOQI%fengguang.wu@intel.com>
Date:   Sun, 17 Dec 2017 04:47:21 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Tom Herbert <tom@...ntonium.net>
Cc:     kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org,
        roopa@...ulusnetworks.com, rohit@...ntonium.net,
        Tom Herbert <tom@...ntonium.net>
Subject: Re: [PATCH v4 net-next 3/6] ila: Call library function
 alloc_bucket_locks

Hi Tom,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Tom-Herbert/net-ILA-notification-mechanism-and-fixes/20171217-041013
config: x86_64-randconfig-x019-201751 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the linux-review/Tom-Herbert/net-ILA-notification-mechanism-and-fixes/20171217-041013 HEAD bdefe11e33bb3662a60476ea17663189974227a0 builds fine.
      It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

   net/ipv6/ila/ila_xlat.c: In function 'alloc_ila_locks':
>> net/ipv6/ila/ila_xlat.c:39:37: error: 'struct ila_net' has no member named 'xlat'
     return alloc_bucket_spinlocks(&ilan->xlat.locks, &ilan->xlat.locks_mask,
                                        ^~
   net/ipv6/ila/ila_xlat.c:39:56: error: 'struct ila_net' has no member named 'xlat'
     return alloc_bucket_spinlocks(&ilan->xlat.locks, &ilan->xlat.locks_mask,
                                                           ^~
   net/ipv6/ila/ila_xlat.c: In function 'ila_exit_net':
   net/ipv6/ila/ila_xlat.c:630:28: error: 'struct ila_net' has no member named 'xlat'
     free_bucket_spinlocks(ilan->xlat.locks);
                               ^~
   net/ipv6/ila/ila_xlat.c: In function 'alloc_ila_locks':
>> net/ipv6/ila/ila_xlat.c:42:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +39 net/ipv6/ila/ila_xlat.c

    36	
    37	static int alloc_ila_locks(struct ila_net *ilan)
    38	{
  > 39		return alloc_bucket_spinlocks(&ilan->xlat.locks, &ilan->xlat.locks_mask,
    40					      MAX_LOCKS, LOCKS_PER_CPU,
    41					      GFP_KERNEL);
  > 42	}
    43	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (31625 bytes)