netdev - Re: [PATCH net-next 2/2 v8] net: ethernet: Add a driver for Gemini gigabit ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbVBanr9fxJY0ShJmZ-AMcjUJEoKbOUs=MMua04HpoCXw@mail.gmail.com>
Date:   Sun, 17 Dec 2017 16:49:19 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Michal Miroslaw <mirq-linux@...e.qmqm.pl>,
        Janos Laube <janos.dev@...il.com>,
        Paulius Zaleckas <paulius.zaleckas@...il.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Tobias Waldvogel <tobias.waldvogel@...il.com>
Subject: Re: [PATCH net-next 2/2 v8] net: ethernet: Add a driver for Gemini
 gigabit ethernet

On Mon, Dec 11, 2017 at 8:16 PM, David Miller <davem@...emloft.net> wrote:
> From: Linus Walleij <linus.walleij@...aro.org>

>> +if NET_VENDOR_CORTINA
>> +
>> +config GEMINI_ETHERNET
>> +     tristate "Gemini Gigabit Ethernet support"
>> +     depends on ARCH_GEMINI
>> +     depends on OF
>> +     select PHYLIB
>> +     select CRC32
>> +     ---help---
>> +       This driver supports StorLink SL351x (Gemini) dual Gigabit Ethernet.
>
> Make this driver buildable anywhere, you don't use any platform architecture
> specific features.

I pushed the recent v9 set where I remove the dep on ARCH_GEMINI
and the autobuilders complain a lot about the use of dma_to_pfn()
which turns out to be a ARM thing from <asm/dma-mapping.h>
included from <linux/dma-mapping.h>.

I will try switching to functions from the generic dma-mapping API
and fix it up and send a v10.

Yours,
Linus Walleij