netdev - Re: [PATCH] trace: reenable preemption if we modify the ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6b68cc7-edb0-6d30-81a5-7f4e33d4e3bf@iogearbox.net>
Date:   Sun, 17 Dec 2017 20:49:25 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Josef Bacik <josef@...icpanda.com>, netdev@...r.kernel.org,
        mhiramat@...nel.org, ast@...nel.org, darrick.wong@...cle.com,
        linux-kernel@...r.kernel.org
Cc:     Josef Bacik <jbacik@...com>
Subject: Re: [PATCH] trace: reenable preemption if we modify the ip

On 12/16/2017 03:42 AM, Josef Bacik wrote:
> From: Josef Bacik <jbacik@...com>
> 
> Things got moved around between the original bpf_override_return patches
> and the final version, and now the ftrace kprobe dispatcher assumes if
> you modified the ip that you also enabled preemption.  Make a comment of
> this and enable preemption, this fixes the lockdep splat that happened
> when using this feature.
> 
> Signed-off-by: Josef Bacik <jbacik@...com>

Applied to bpf-next with Fixes tag, thanks Josef.