netdev - Re: [PATCH][netfilter-next] netfilter: conntrack: make struct nf_conntrack_l4proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171218105915.cjqsqe2nmahm5yji@salvia>
Date:   Mon, 18 Dec 2017 11:59:15 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Florian Westphal <fw@...len.de>
Cc:     Colin King <colin.king@...onical.com>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        "David S . Miller" <davem@...emloft.net>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][netfilter-next] netfilter: conntrack: make struct
 nf_conntrack_l4proto_gre4 static

On Mon, Dec 11, 2017 at 10:18:05AM +0100, Florian Westphal wrote:
> Colin King <colin.king@...onical.com> wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > The structure nf_conntrack_l4proto_gre4  is local to the source and does
> > not need to be in global scope, so make it static.
> 
> This bug was added in
> commit b9679a9fd3a7d36ea3deb2864a00cc413c5aae28
> netfilter: conntrack: l4 protocol trackers can be const

I have added Fixes: ... here.

> > -struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = {
> > +static struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = {
> 
> This should be 'static const'.

I have mangled this patch to make it static const.

So Colin doesn't need to resend.

If there's anything else, let me know, I'll toss it and wait for a v2,
as you prefer.

Thanks.