netdev - Re: [PATCH] wil6210: fix build warnings without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zi6gje6j.fsf@kamboji.qca.qualcomm.com>
Date:   Mon, 18 Dec 2017 14:36:37 +0000
From:   Kalle Valo <kvalo@....qualcomm.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     qca_merez <qca_merez@....qualcomm.com>,
        QCA_ailizaro <QCA_ailizaro@....qualcomm.com>,
        qca_dlansky <qca_dlansky@....qualcomm.com>,
        QCA_hkadmany <QCA_hkadmany@....qualcomm.com>,
        qca_liord <qca_liord@....qualcomm.com>,
        QCA_gidons <QCA_gidons@....qualcomm.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        wil6210 <wil6210@....qualcomm.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wil6210: fix build warnings without CONFIG_PM

Arnd Bergmann <arnd@...db.de> writes:

> The #ifdef checks are hard to get right, in this case some functions
> should have been left inside a CONFIG_PM_SLEEP check as seen by this
> message:
>
> drivers/net/wireless/ath/wil6210/pcie_bus.c:489:12: error: 'wil6210_pm_resume' defined but not used [-Werror=unused-function]
> drivers/net/wireless/ath/wil6210/pcie_bus.c:484:12: error: 'wil6210_pm_suspend' defined but not used [-Werror=unused-function]
>
> Using an __maybe_unused is easier here, so I'm replacing all the
> other #ifdef in this file as well for consistency.
>
> Fixes: 94162666cd51 ("wil6210: run-time PM when interface down")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

A note to myself (unfortunately patchwork doesn't have any way to add
notes to patches): 94162666cd51 is in wireless-drivers-next so this
patch should also go to -next.

-- 
Kalle Valo