lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Dec 2017 17:25:05 -0800 From: John Fastabend <john.fastabend@...il.com> To: Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org Subject: Re: [Patch net-next] net_sched: properly check for empty skb array on error path On 12/18/2017 02:34 PM, Cong Wang wrote: > First, the check of &q->ring.queue against NULL is wrong, it > is always false. We should check the value rather than the address. > Thanks. > Secondly, we need the same check in pfifo_fast_reset() too, > as both ->reset() and ->destroy() are called in qdisc_destroy(). > not that it hurts to have the check here, but if init fails in qdisc_create it seems only ->destroy() is called without a ->reset(). Is there another path for init() to fail that I'm missing. > Fixes: c5ad119fb6c0 ("net: sched: pfifo_fast use skb_array") > Reported-by: syzbot <syzkaller@...glegroups.com> > Cc: John Fastabend <john.fastabend@...il.com> > Signed-off-by: Cong Wang <xiyou.wangcong@...il.com> > --- > net/sched/sch_generic.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >
Powered by blists - more mailing lists