netdev - Re: [PATCH v2,net-next 1/2] ip_gre: fix potential memory leak in erspan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171219.103633.721139612524381957.davem@davemloft.net>
Date:   Tue, 19 Dec 2017 10:36:33 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     yanhaishuang@...s.chinamobile.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        u9012063@...il.com
Subject: Re: [PATCH v2,net-next 1/2] ip_gre: fix potential memory leak in
 erspan_rcv

From: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
Date: Sat, 16 Dec 2017 10:48:38 +0800

> If md is NULL, tun_dst must be freed, otherwise it will cause memory
> leak.
> 
> Fixes: 1a66a836da6 ("gre: add collect_md mode to ERSPAN tunnel")
> Cc: William Tu <u9012063@...il.com>
> Signed-off-by: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
> 
> Change since v2:
>   * Rebase on latest master branch.
>   * Correct wrong fix information.

Please do not put a changelog after the fixes and signoff tags, those tags must
appear last in the commit message.

Thank you.