netdev - Re: [patch net-next] mlxsw: spectrum: Add "spectrum" prefix macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171219.110906.560509930655165996.davem@davemloft.net>
Date:   Tue, 19 Dec 2017 11:09:06 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     joe@...ches.com
Cc:     jiri@...nulli.us, netdev@...r.kernel.org, arkadis@...lanox.com,
        idosch@...lanox.com, mlxsw@...lanox.com
Subject: Re: [patch net-next] mlxsw: spectrum: Add "spectrum" prefix macro

From: Joe Perches <joe@...ches.com>
Date: Sun, 17 Dec 2017 08:25:00 -0800

> On Sun, 2017-12-17 at 17:15 +0100, Jiri Pirko wrote:
>> From: Arkadi Sharshevsky <arkadis@...lanox.com>
>> 
>> Add "spectrum" string prefix macro for error strings.
> []
>> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
> []
>> @@ -4168,13 +4168,11 @@ mlxsw_sp_master_lag_check(struct mlxsw_sp *mlxsw_sp,
>>  	u16 lag_id;
>>  
>>  	if (mlxsw_sp_lag_index_get(mlxsw_sp, lag_dev, &lag_id) != 0) {
>> -		NL_SET_ERR_MSG(extack,
>> -			       "spectrum: Exceeded number of supported LAG devices");
>> +		NL_SET_ERR_MSG(extack, MLXSW_SP_PREFIX "Exceeded number of supported LAG devices");
> 
> Perhaps use NL_SET_ERR_MSG_MOD instead.

Yeah that probably makes sense.