netdev - Re: [PATCH iproute2 0/3] ip/tunnels: Reuse code, vti6 zero endpoint support and minor cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171219081911.6d316d83@xeon-e3>
Date:   Tue, 19 Dec 2017 08:19:11 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Serhey Popovych <serhe.popovych@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 0/3] ip/tunnels: Reuse code, vti6 zero endpoint
 support and minor cleanup

On Mon, 18 Dec 2017 19:48:02 +0200
Serhey Popovych <serhe.popovych@...il.com> wrote:

> In this series I present next set of improvements:
> 
>   1) Use tnl_parse_key() to avoid code duplication in tunnel
>      configuration via netlink code.
> 
>   2) Trivial: use IN6ADDR_ANY_INIT instead of open coded
>      initialization of local/remote endpoint in ip6tnl code.
> 
>   3) Trivial: drop additional checks for zero endpoint
>      in vti6 code. This completes and unifies support for
>      unconfiguring local/remote endpoint for tunnel.
> 
> See individual patch description message for details.
> 
> Thanks,
> Serhii
> 
> Serhey Popovych (3):
>   ip/tunnel: Use tnl_parse_key() to parse tunnel key
>   link_ip6tnl: Use IN6ADDR_ANY_INIT to initialize local/remote
>     endpoints
>   link_vti6: Always add local/remote endpoint attributes
> 
>  ip/link_gre.c    |   45 +++++----------------------------------------
>  ip/link_gre6.c   |   45 +++++----------------------------------------
>  ip/link_ip6tnl.c |    4 ++--
>  ip/link_vti.c    |   45 +++++----------------------------------------
>  ip/link_vti6.c   |   51 +++++++--------------------------------------------
>  ip/tunnel.c      |    5 +++--
>  6 files changed, 27 insertions(+), 168 deletions(-)
> 

Applied, thanks