netdev - Re: [PATCH net] ip_gre: remove the incorrect mtu limit for ipgre tap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Dec 2017 13:46:14 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, jarod@...hat.com
Subject: Re: [PATCH net] ip_gre: remove the incorrect mtu limit for ipgre
 tap

From: Xin Long <lucien.xin@...il.com>
Date: Mon, 18 Dec 2017 14:24:35 +0800

> ipgre tap driver calls ether_setup(), after commit 61e84623ace3
> ("net: centralize net_device min/max MTU checking"), the range
> of mtu is [min_mtu, max_mtu], which is [68, 1500] by default.
> 
> It causes the dev mtu of the ipgre tap device to not be greater
> than 1500, this limit value is not correct for ipgre tap device.
> 
> Besides, it's .change_mtu already does the right check. So this
> patch is just to set max_mtu as 0, and leave the check to it's
> .change_mtu.
> 
> Fixes: 61e84623ace3 ("net: centralize net_device min/max MTU checking")
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied.