netdev - Re: [PATCH net-next v5 0/5] Introduce NETIF_F_GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171219.142431.1940142843749180845.davem@davemloft.net>
Date:   Tue, 19 Dec 2017 14:24:31 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     marcelo.leitner@...il.com
Cc:     michael.chan@...adcom.com, netdev@...r.kernel.org,
        andrew.gospodarek@...adcom.com
Subject: Re: [PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW

From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Date: Tue, 19 Dec 2017 17:04:27 -0200

> I understand that for all that matters, the hardware operations
> involved on GRO_HW are really for only 1 packet, so it would make
> sense to count it as 1. OTOH, this bump may cause additional pressure
> in other places as in fact we are allowing more packets in in a given
> cycle.

More data, but not more packets or (realistically) "work".

The stack is going to parse only one SKB, one set of networking
headers, do one route lookup, one socket demux, etc.

In that view, counting the HW GRO packet as only one frame is
appropriate.