netdev - Re: [PATCH][next] bpf: make function skip_callee static and return NULL rather than 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22724a21-5e99-dddb-31f1-ae8e1916d2ff@iogearbox.net>
Date:   Tue, 19 Dec 2017 01:28:18 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Colin King <colin.king@...onical.com>,
        Alexei Starovoitov <ast@...nel.org>, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] bpf: make function skip_callee static and return
 NULL rather than 0

On 12/18/2017 06:47 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Function skip_callee is local to the source and does not need to
> be in global scope, so make it static. Also return NULL rather than 0.
> Cleans up two sparse warnings:
> 
> symbol 'skip_callee' was not declared. Should it be static?
> Using plain integer as NULL pointer
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Makes sense, applied to bpf-next, thanks Colin!