netdev - Re: [PATCH v3 net-next 6/6] tls: Add generic NIC offload infrastructure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201712191430.MeDYuciS%fengguang.wu@intel.com>
Date:   Tue, 19 Dec 2017 15:01:51 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Ilya Lesokhin <ilyal@...lanox.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, davem@...emloft.net,
        davejwatson@...com, tom@...bertland.com,
        hannes@...essinduktion.org, borisp@...lanox.com,
        aviadye@...lanox.com, liranl@...lanox.com,
        Ilya Lesokhin <ilyal@...lanox.com>
Subject: Re: [PATCH v3 net-next 6/6] tls: Add generic NIC offload
 infrastructure.

Hi Ilya,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Ilya-Lesokhin/tls-Add-generic-NIC-offload-infrastructure/20171219-140819
config: tile-allmodconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=tile 

All errors (new ones prefixed by >>):

   net/tls/tls_device_fallback.c: In function 'update_chksum':
>> net/tls/tls_device_fallback.c:190:16: error: implicit declaration of function 'csum_ipv6_magic'; did you mean 'csum_tcpudp_magic'? [-Werror=implicit-function-declaration]
      th->check = ~csum_ipv6_magic(&ipv6h->saddr, &ipv6h->daddr,
                   ^~~~~~~~~~~~~~~
                   csum_tcpudp_magic
   cc1: some warnings being treated as errors

vim +190 net/tls/tls_device_fallback.c

   166	
   167	static inline void update_chksum(struct sk_buff *skb, int headln)
   168	{
   169		/* Can't use icsk->icsk_af_ops->send_check here because the ip addresses
   170		 * might have been changed by NAT.
   171		 */
   172	
   173		const struct ipv6hdr *ipv6h;
   174		const struct iphdr *iph;
   175		struct tcphdr *th = tcp_hdr(skb);
   176		int datalen = skb->len - headln;
   177	
   178		/* We only changed the payload so if we are using partial we don't
   179		 * need to update anything.
   180		 */
   181		if (likely(skb->ip_summed == CHECKSUM_PARTIAL))
   182			return;
   183	
   184		skb->ip_summed = CHECKSUM_PARTIAL;
   185		skb->csum_start = skb_transport_header(skb) - skb->head;
   186		skb->csum_offset = offsetof(struct tcphdr, check);
   187	
   188		if (skb->sk->sk_family == AF_INET6) {
   189			ipv6h = ipv6_hdr(skb);
 > 190			th->check = ~csum_ipv6_magic(&ipv6h->saddr, &ipv6h->daddr,
   191						     datalen, IPPROTO_TCP, 0);
   192		} else {
   193			iph = ip_hdr(skb);
   194			th->check = ~csum_tcpudp_magic(iph->saddr, iph->daddr, datalen,
   195						       IPPROTO_TCP, 0);
   196		}
   197	}
   198	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (51390 bytes)