netdev - Re: [PATCH v5 3/6] perf: implement pmu perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171220100301.bvacqfua4hj2onzq@hirez.programming.kicks-ass.net>
Date:   Wed, 20 Dec 2017 11:03:02 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Song Liu <songliubraving@...com>
Cc:     rostedt@...dmis.org, mingo@...hat.com, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        daniel@...earbox.net, kernel-team@...com
Subject: Re: [PATCH v5 3/6] perf: implement pmu perf_kprobe

On Wed, Dec 06, 2017 at 02:45:15PM -0800, Song Liu wrote:
> @@ -8537,7 +8620,7 @@ static int perf_event_set_filter(struct perf_event *event, void __user *arg)
>  	char *filter_str;
>  	int ret = -EINVAL;
>  
> -	if ((event->attr.type != PERF_TYPE_TRACEPOINT ||
> +	if ((!perf_event_is_tracing(event) ||
>  	     !IS_ENABLED(CONFIG_EVENT_TRACING)) &&
>  	    !has_addr_filter(event))
>  		return -EINVAL;

You actually missed an instance later in this same function... fixing
that.