netdev - Re: [PATCH net-next] qed*: Utilize FW 8.33.1.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171220.115403.2203972051867900874.davem@davemloft.net>
Date:   Wed, 20 Dec 2017 11:54:03 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     Tomer.Tayar@...ium.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-scsi@...r.kernel.org,
        Ariel.Elior@...ium.com, Michal.Kalderon@...ium.com,
        Yuval.Bason@...ium.com, Ram.Amrani@...ium.com,
        Manish.Chopra@...ium.com, Chad.Dupuis@...ium.com,
        Manish.Rangankar@...ium.com
Subject: Re: [PATCH net-next] qed*: Utilize FW 8.33.1.0

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Tue, 19 Dec 2017 15:46:51 -0800

> On Tue, 19 Dec 2017 16:05:23 +0200, Tomer Tayar wrote:
>> Sorry for the very long patch.
>> The firmware changes are spread all over w/o a good modularity.
> 
> Rings false.  Significant portion of this patch is just whitespace 
> and comment changes.

Totally agreed.

This thing is beyond huge already, adding unrelated whitespace and
comment changes make reviewing it even more impossible.