netdev - Re: [PATCH v1] net: dwc-xlgmac: Get rid of custom hex_dump_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171220.124519.1049053649915840058.davem@davemloft.net>
Date:   Wed, 20 Dec 2017 12:45:19 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     andriy.shevchenko@...ux.intel.com
Cc:     jiedeng@...opsys.com, Jose.Abreu@...opsys.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH v1] net: dwc-xlgmac: Get rid of custom
 hex_dump_to_buffer()

From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Date: Tue, 19 Dec 2017 20:03:06 +0200

> +		hex_dump_to_buffer(&skb->data[i], len, 32, 1, buffer, 128, false);

Please make the changes here that were requested for the amd-xgbe version of
this patch.  In particular, use "sizeof(buffer)" instead of the magic constant 128.

Thank you.