[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20171220.125858.1378708055295289661.davem@davemloft.net>
Date: Wed, 20 Dec 2017 12:58:58 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: saeedm@...lanox.com
Cc: dledford@...hat.com, netdev@...r.kernel.org,
linux-rdma@...r.kernel.org, leonro@...lanox.com, markb@...lanox.com
Subject: Re: [for-next 07/11] net/mlx5: E-Switch, Create generic header
struct to be used by representors
From: Saeed Mahameed <saeedm@...lanox.com>
Date: Tue, 19 Dec 2017 12:33:36 -0800
> +static int esw_offloads_load_reps(struct mlx5_eswitch *esw, int nvports)
> +{
> + u8 rep_type = 0;
> + int err;
> +
> + while (rep_type < NUM_REP_TYPES) {
> + err = esw_offloads_load_reps_type(esw, nvports,
> + rep_type);
> + if (err)
> + goto err_reps;
> + rep_type++;
> + }
Please, don't obfuscate what is a normal for() loop:
for (rep_type = 0; rep_type < NUM_REP_TYPES; rep_type++)
Thanks.
Powered by blists - more mailing lists