netdev - Re: [PATCH v2,net-next] ip6_gre: fix a pontential issue in ip6erspan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <469F603D-3EB9-4A26-A4B0-8FF6B17C423A@cmss.chinamobile.com>
Date:   Wed, 20 Dec 2017 09:27:33 +0800
From:   Haishuang Yan <yanhaishuang@...s.chinamobile.com>
To:     David Miller <davem@...emloft.net>
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        u9012063@...il.com
Subject: Re: [PATCH v2,net-next] ip6_gre: fix a pontential issue in
 ip6erspan_rcv



> On 2017年12月19日, at 下午11:34, David Miller <davem@...emloft.net> wrote:
> 
> From: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
> Date: Sat, 16 Dec 2017 10:25:25 +0800
> 
>> pskb_may_pull() can change skb->data, so we need to load ipv6h/ershdr at
>> the right place.
>> 
>> Fixes: 5a963eb61b7c ("ip6_gre: Add ERSPAN native tunnel support")
>> Acked-by: William Tu <u9012063@...il.com>
>> Cc: William Tu <u9012063@...il.com>
>> Signed-off-by: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
> 
> This patch does not apply:
> 
>> +	ipv6h = ipv6_hdr(skb);
>> +	ershdr = (struct erspan_base_hdr *)skb->data;
>> 	ver = (ntohs(ershdr->ver_vlan) & VER_MASK) >> VER_OFFSET;
>> 	tpi->key = cpu_to_be32(ntohs(ershdr->session_id) & ID_MASK);
>> 	pkt_md = (struct erspan_metadata *)(ershdr + 1);
> 
> There is not "pkt_md = ..." assignment in net-next on this line.
> 

Okay, I will fix it and resubmit another commit, thanks.