netdev - Re: [PATCH v2] net: ibm: emac: support RGMII-[RX|TX]ID phymode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171220.162018.1758886391267842722.davem@davemloft.net>
Date:   Wed, 20 Dec 2017 16:20:18 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     chunkeey@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch,
        christophe.jaillet@...adoo.fr, benh@...nel.crashing.org
Subject: Re: [PATCH v2] net: ibm: emac: support RGMII-[RX|TX]ID phymode

From: Christian Lamparter <chunkeey@...il.com>
Date: Wed, 20 Dec 2017 22:07:43 +0100

> Yeah, I can do that. no problem. 
> 
> Question is, should I also replace the rgmii_mode_name() with phy_modes() too?
> 
> The only user of rgmii_mode_name() is this notice printk in rgmii_attach():
> <http://elixir.free-electrons.com/linux/latest/source/drivers/net/ethernet/ibm/emac/rgmii.c#L117>

I would recommend you use phy_modes() instead of that custom rgmii_mode_name() thing,
yes.

Thanks for asking.