netdev - Re: [PATCH V2 net-next 02/17] net: hns3: add support to modify tqps number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96a532c2-c557-532f-7bfe-29301977bb5a@huawei.com>
Date:   Wed, 20 Dec 2017 14:15:51 +0800
From:   "lipeng (Y)" <lipeng321@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <salil.mehta@...wei.com>
Subject: Re: [PATCH V2 net-next 02/17] net: hns3: add support to modify tqps
 number



On 2017/12/20 3:18, David Miller wrote:
> From: Lipeng <lipeng321@...wei.com>
> Date: Tue, 19 Dec 2017 12:02:24 +0800
>
>> @@ -2651,6 +2651,19 @@ static int hns3_get_ring_config(struct hns3_nic_priv *priv)
>>   	return ret;
>>   }
>>   
>> +static void hns3_put_ring_config(struct hns3_nic_priv *priv)
>> +{
>> +	struct hnae3_handle *h = priv->ae_handle;
>> +	u16 i;
>> +
>> +	for (i = 0; i < h->kinfo.num_tqps; i++) {
> Please use a plain "int" for index iteration loops like this since
> that is the canonical type to use.
will check and fix this , Thanks.
>> +static void hclge_release_tqp(struct hclge_vport *vport)
>> +{
>> +	struct hnae3_knic_private_info *kinfo = &vport->nic.kinfo;
>> +	struct hclge_dev *hdev = vport->back;
>> +	u16 i;
>> +
>> +	for (i = 0; i < kinfo->num_tqps; i++) {
> Likewise.
>
> .
>