netdev - Re: [PATCH RFC 00/18] r8169: separate r8168 driver and add experimental phylib support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171221.161603.944790580293624594.davem@davemloft.net>
Date:   Thu, 21 Dec 2017 16:16:03 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, nic_swsd@...ltek.com, hau@...ltek.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH RFC 00/18] r8169: separate r8168 driver and add
 experimental phylib support

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Thu, 21 Dec 2017 21:38:11 +0100

> This experimental series separates drivers for PCI / PCIE NIC's and
> adds initial phylib support to the separated r8168 driver.

Thanks for working on this.

The RX and TX ring handling is basically going to be identical
for the two chips, so it's very undesirable to duplicate that
code in the two drivers.

Getting good test coverage is going to be extremely challenging
for this, so the more code you share between the two drivers
rather than duplicate the better.