netdev - Re: [PATCH net] ipv6: Honor specified parameters in fibmatch lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90b66952-d502-5430-e988-fa3e4422ef91@gmail.com>
Date:   Wed, 20 Dec 2017 19:54:47 -0700
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, roopa@...ulusnetworks.com, mlxsw@...lanox.com
Subject: Re: [PATCH net] ipv6: Honor specified parameters in fibmatch lookup

On 12/20/17 3:28 AM, Ido Schimmel wrote:
> @@ -4327,6 +4321,15 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh,
>  		goto errout;
>  	}
>  
> +	if (fibmatch && rt->dst.from) {
> +		struct rt6_info *ort = container_of(rt->dst.from,
> +						    struct rt6_info, dst);
> +
> +		dst_hold(&ort->dst);
> +		ip6_rt_put(rt);
> +		rt = ort;
> +	}
> +
>  	skb = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL);
>  	if (!skb) {
>  		ip6_rt_put(rt);
> 


That's going to need a fixup on the net-next merge -- from was moved
from dst to rt6_info. Change wise it looks ok to me.

Acked-by: David Ahern <dsahern@...il.com>