netdev - Re: [PATCH bpf-next] tools/bpf: adjust rlimit RLIMIT_MEMLOCK for test_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171221032139.i3he3hus2noc2lkl@ast-mbp>
Date:   Wed, 20 Dec 2017 19:21:41 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     ast@...com, daniel@...earbox.net, guro@...com,
        netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH bpf-next] tools/bpf: adjust rlimit RLIMIT_MEMLOCK for
 test_dev_cgroup

On Wed, Dec 20, 2017 at 10:37:08AM -0800, Yonghong Song wrote:
> The default rlimit RLIMIT_MEMLOCK is 64KB. In certain cases,
> e.g. in a test machine mimicking our production system, this test may
> fail due to unable to charge the required memory for prog load:
> 
>   $ ./test_dev_cgroup
>   libbpf: load bpf program failed: Operation not permitted
>   libbpf: failed to load program 'cgroup/dev'
>   libbpf: failed to load object './dev_cgroup.o'
>   Failed to load DEV_CGROUP program
>   ...
> 
> Changing the default rlimit RLIMIT_MEMLOCK to unlimited
> makes the test pass.
> 
> This patch also fixed a problem where when bpf_prog_load fails,
> cleanup_cgroup_environment() should not be called since
> setup_cgroup_environment() has not been invoked. Otherwise,
> the following confusing message will appear:
>   ...
>   (/home/yhs/local/linux/tools/testing/selftests/bpf/cgroup_helpers.c:95:
>    errno: No such file or directory) Opening Cgroup Procs: /mnt/cgroup.procs
>   ...
> 
> Signed-off-by: Yonghong Song <yhs@...com>

Applied, Thanks Yonghong.