netdev - Re: [PATCH net-next] net/trace: fix printk format in inet_sock_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c92b431d-1a62-4c25-61f2-3a66dae97a08@cogentembedded.com>
Date:   Fri, 22 Dec 2017 20:04:55 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Yafang Shao <laoar.shao@...il.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net/trace: fix printk format in
 inet_sock_set_state

Hello!

On 12/22/2017 06:37 PM, Yafang Shao wrote:

> There's a space character missed in the printk messages.
> This error should be prevented with checkscript.pl, but it couldn't caught
                                                                      ^ be?

> by running with "checkscript.pl -f xxxx.patch", that's what I had run
> before.
> What a carelessness.

    You generally don't need to break up the messages violating 80-column 
limit, and checkpatch.pl should be aware of this...

> Fixes: 563e0bb0dc74("net: tracepoint: replace tcp_set_state tracepoint with
> inet_sock_set_state tracepoint")
> Signed-off-by: Yafang Shao <laoar.shao@...il.com>
[...]

MBR, Sergei