netdev - RE: [Intel-wired-lan] [PATCH] e1000e: Fix e1000_check_for_copper_link_ich8lan return value.

Open Source and information security mailing list archives

Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B8C71D3A3@ORSMSX103.amr.corp.intel.com>
Date:   Fri, 22 Dec 2017 22:00:00 +0000
From:   "Brown, Aaron F" <aaron.f.brown@...el.com>
To:     "Neftin, Sasha" <sasha.neftin@...el.com>,
        Benjamin Poirier <bpoirier@...e.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:     Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        Gabriel C <nix.or.die@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Christian Hesse <list@...rm.de>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH] e1000e: Fix
 e1000_check_for_copper_link_ich8lan return value.

> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@...osl.org] On
> Behalf Of Neftin, Sasha
> Sent: Wednesday, December 20, 2017 10:57 PM
> To: Benjamin Poirier <bpoirier@...e.com>; Kirsher, Jeffrey T
> <jeffrey.t.kirsher@...el.com>
> Cc: Ben Hutchings <ben.hutchings@...ethink.co.uk>; Gabriel C
> <nix.or.die@...il.com>; netdev@...r.kernel.org; Christian Hesse
> <list@...rm.de>; stable@...r.kernel.org; linux-kernel@...r.kernel.org;
> intel-wired-lan@...ts.osuosl.org
> Subject: Re: [Intel-wired-lan] [PATCH] e1000e: Fix
> e1000_check_for_copper_link_ich8lan return value.
> 
> On 11/12/2017 9:26, Benjamin Poirier wrote:
> > e1000e_check_for_copper_link() and
> e1000_check_for_copper_link_ich8lan()
> > are the two functions that may be assigned to mac.ops.check_for_link
> when
> > phy.media_type == e1000_media_type_copper. Commit 19110cfbb34d
> ("e1000e:
> > Separate signaling for link check/link up") changed the meaning of the
> > return value of check_for_link for copper media but only adjusted the first
> > function. This patch adjusts the second function likewise.
> >
> > Reported-by: Christian Hesse <list@...rm.de>
> > Reported-by: Gabriel C <nix.or.die@...il.com>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=198047
> > Fixes: 19110cfbb34d ("e1000e: Separate signaling for link check/link up")
> > Tested-by: Christian Hesse <list@...rm.de>
> > Signed-off-by: Benjamin Poirier <bpoirier@...e.com>
> > ---
> >   drivers/net/ethernet/intel/e1000e/ich8lan.c | 11 ++++++++---
> >   1 file changed, 8 insertions(+), 3 deletions(-)
> >

Tested-by: Aaron Brown <aaron.f.brown@...el.com>

> Acked by sasha.neftin@...el.com
> 
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives