netdev - Re: [PATCH RFC 12/18] r8168: switch to phy_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82fec402-6ad0-4a42-0e8f-916ca28dff14@gmail.com>
Date:   Sat, 23 Dec 2017 00:01:58 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        Chun-Hao Lin <hau@...ltek.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH RFC 12/18] r8168: switch to phy_mii_ioctl

Am 22.12.2017 um 11:00 schrieb Andrew Lunn:
>>  static int rtl8168_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
>>  {
>> -	struct rtl8168_private *tp = netdev_priv(dev);
>> -	struct mii_ioctl_data *data = if_mii(ifr);
>> +	if (!netif_running(dev))
>> +		return -ENODEV;
> 
> It is sometimes useful to be able to prod and poke the PHY when the
> MAC is not running. Is this limit because of power saving?
> 
Actually I'm not 100% sure, I just kept the existing logic.
When checking other users of phy_mii_ioctl I saw that it is
a typical pattern to return an error if the interface is down.

> Otherwise, this patch looks good.
> 
> Thanks
> 	Andrew
>