netdev - Re: [PATCH RFC 09/18] r8168: use genphy_soft_reset instead of open coding the soft reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171222095706.GF2431@lunn.ch>
Date:   Fri, 22 Dec 2017 10:57:06 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        Chun-Hao Lin <hau@...ltek.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH RFC 09/18] r8168: use genphy_soft_reset instead of open
 coding the soft reset

On Thu, Dec 21, 2017 at 09:50:28PM +0100, Heiner Kallweit wrote:
> Use genphy_soft_reset instead of open coding the soft reset.

Hi Heiner

At this point, you have swapped over the phylib. Does one of the
drivers in drivers/net/phy now take control of the PHY? Does the PHY
ID match one of those in realtek.c?

The PHY driver and phylib should be responsible for resetting the
PHY. The MAC driver should not need to do this.

     Andrew