netdev - Re: [PATCH RFC 12/18] r8168: switch to phy_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171222100042.GI2431@lunn.ch>
Date:   Fri, 22 Dec 2017 11:00:42 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        Chun-Hao Lin <hau@...ltek.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH RFC 12/18] r8168: switch to phy_mii_ioctl

>  static int rtl8168_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
>  {
> -	struct rtl8168_private *tp = netdev_priv(dev);
> -	struct mii_ioctl_data *data = if_mii(ifr);
> +	if (!netif_running(dev))
> +		return -ENODEV;

It is sometimes useful to be able to prod and poke the PHY when the
MAC is not running. Is this limit because of power saving?

Otherwise, this patch looks good.

Thanks
	Andrew