netdev - Re: [PATCH RFC 17/18] r8168: remove use of struct mii_if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171222102110.GL2431@lunn.ch>
Date:   Fri, 22 Dec 2017 11:21:10 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        Chun-Hao Lin <hau@...ltek.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH RFC 17/18] r8168: remove use of struct mii_if_info

On Thu, Dec 21, 2017 at 09:50:52PM +0100, Heiner Kallweit wrote:
> @@ -1188,21 +1188,6 @@ static void rtl_w0w1_phy(struct rtl8168_private *tp, int reg_addr, int p, int m)
>  	rtl_writephy(tp, reg_addr, (val & ~m) | p);
>  }
>  
> -static void rtl_mdio_write(struct net_device *dev, int phy_id, int location,
> -			   int val)
> -{
> -	struct rtl8168_private *tp = netdev_priv(dev);
> -
> -	rtl_writephy(tp, location, val);
> -}
> -
> -static int rtl_mdio_read(struct net_device *dev, int phy_id, int location)
> -{
> -	struct rtl8168_private *tp = netdev_priv(dev);
> -
> -	return rtl_readphy(tp, location);
> -}

Hi Heiner

With these two gone, it would be nice to rename r8168_mdio_read_reg()
and r8168_mdio_write_reg() to rtl_mdio_read() and rtl_mdio_write().

    Andrew