netdev - Re: [PATCH net-next] virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be339a85-4368-257e-5f23-d0e35c77cd5b@lab.ntt.co.jp>
Date:   Mon, 25 Dec 2017 20:45:36 +0900
From:   Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>, netdev@...r.kernel.org,
        virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH net-next] virtio_net: Add ethtool stats

On 2017/12/25 3:16, Stephen Hemminger wrote:
> On Wed, 20 Dec 2017 13:40:37 +0900
> Toshiaki Makita <makita.toshiaki@....ntt.co.jp> wrote:
> 
>> +
>> +static const struct virtnet_gstats virtnet_gstrings_stats[] = {
>> +	{ "rx_packets",		VIRTNET_NETDEV_STAT(rx_packets) },
>> +	{ "tx_packets",		VIRTNET_NETDEV_STAT(tx_packets) },
>> +	{ "rx_bytes",		VIRTNET_NETDEV_STAT(rx_bytes) },
>> +	{ "tx_bytes",		VIRTNET_NETDEV_STAT(tx_bytes) },
>> +	{ "rx_dropped",		VIRTNET_NETDEV_STAT(rx_dropped) },
>> +	{ "rx_length_errors",	VIRTNET_NETDEV_STAT(rx_length_errors) },
>> +	{ "rx_frame_errors",	VIRTNET_NETDEV_STAT(rx_frame_errors) },
>> +	{ "tx_dropped",		VIRTNET_NETDEV_STAT(tx_dropped) },
>> +	{ "tx_fifo_errors",	VIRTNET_NETDEV_STAT(tx_fifo_errors) },
>> +};
>> +
> 
> Please do not merge pre-existing global stats into ethtool.
> It just duplicates existing functionality.

Thanks for the feedback.
I thought it's handy to be able to check stats like this in ethtool as
well. Some drivers like ixgbe and mlx5 do similar thing.
I can remove these duplicate stats (unless anyone has objection).

-- 
Toshiaki Makita