netdev - Re: [PATCH iproute2 1/3] vxcan,veth: Forbid "type" for peer device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171226090535.51ac43ef@xeon-e3>
Date:   Tue, 26 Dec 2017 09:05:35 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Serhey Popovych <serhe.popovych@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 1/3] vxcan,veth: Forbid "type" for peer device

On Wed, 20 Dec 2017 09:37:29 +0200
Serhey Popovych <serhe.popovych@...il.com> wrote:

> It is already given for original device we configure this
> peer for.
> 
> Results from following command before/after change applied
> are shown below:
> 
>   $ ip link add dev veth1a type veth peer name veth1b \
>                            type veth peer name veth1c
> 
> Before:
> -------
> 
> <no output, no netdevs created>
> 
> After:
> ------
> 
> Error: argument "type" is wrong: not supported for peer
> 
> Signed-off-by: Serhey Popovych <serhe.popovych@...il.com>

This makes a lot of sense.
Maybe the better error message would be to use duparg() since
that is the most likely cause of the user error.