lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Dec 2017 12:58:15 -0500 (EST) From: David Miller <davem@...emloft.net> To: hayashi.kunihiko@...ionext.com Cc: netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com, robh+dt@...nel.org, mark.rutland@....com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, yamada.masahiro@...ionext.com, masami.hiramatsu@...aro.org, jaswinder.singh@...aro.org Subject: Re: [PATCH net-next v7 2/2] net: ethernet: socionext: add AVE ethernet driver From: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com> Date: Thu, 21 Dec 2017 20:12:56 +0900 > + writel(AVE_TXDC_ADDR_START > + | (((priv->tx.ndesc * priv->desc_size) << 16) & AVE_TXDC_SIZE), > + priv->base + AVE_TXDC); ... > + writel(AVE_RXDC0_ADDR_START > + | (((priv->rx.ndesc * priv->desc_size) << 16) & AVE_RXDC0_SIZE), > + priv->base + AVE_RXDC0); ... > + cmdsts = AVE_STS_OWN | AVE_STS_1ST | AVE_STS_LAST > + | (skb->len & AVE_STS_PKTLEN_TX_MASK); Please do not begin lines with operators, instead put them at the end of the previous line, f.e.: cmdsts = AVE_STS_OWN | AVE_STS_1ST | AVE_STS_LAST | (skb->len & AVE_STS_PKTLEN_TX_MASK); Thank you.
Powered by blists - more mailing lists