netdev - Re: [net 1/1] tipc: fix memory leak of group member when peer node is lost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171226.130656.701776177319782594.davem@davemloft.net>
Date:   Tue, 26 Dec 2017 13:06:56 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org,
        mohan.krishna.ghanta.krishnamurthy@...csson.com,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net 1/1] tipc: fix memory leak of group member when peer node
 is lost

From: Jon Maloy <jon.maloy@...csson.com>
Date: Thu, 21 Dec 2017 14:36:34 +0100

> When a group member receives a member WITHDRAW event, this might have
> two reasons: either the peer member is leaving the group, or the link
> to the member's node has been lost.
> 
> In the latter case we need to issue a DOWN event to the user right away,
> and let function tipc_group_filter_msg() perform delete of the member
> item. However, in this case we miss to change the state of the member
> item to MBR_LEAVING, so the member item is not deleted, and we have a
> memory leak.
> 
> We now separate better between the four sub-cases of a WITHRAW event
> and make sure that each case is handled correctly.
> 
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied.