netdev - Re: [PATCHv3 1/3] dt-bindings: net: Add DT bindings for Socionext Netsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f42d29cc-6b3f-20dc-3f42-bc9a9fc7ce4a@gmail.com>
Date:   Tue, 26 Dec 2017 11:34:26 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, jassisinghbrar@...il.com
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        davem@...emloft.net, arnd.bergmann@...aro.org,
        ard.biesheuvel@...aro.org, robh+dt@...nel.org,
        mark.rutland@....com, masami.hiramatsu@...aro.org,
        Jassi Brar <jaswinder.singh@...aro.org>
Subject: Re: [PATCHv3 1/3] dt-bindings: net: Add DT bindings for Socionext
 Netsec

On 12/21/2017 05:55 AM, Andrew Lunn wrote:
>> +- mdio device tree subnode: When the Netsec has a phy connected to its local
>> +		mdio, there must be device tree subnode with the following
>> +		required properties:
>> +
>> +	- compatible: Must be "socionext,snq-mdio".
> 
> Is there a need for a compatible string? Is there different versions
> of the MDIO bus hardware? If it was an independent MDIO bus driver,
> then yes, you need a compatible string. But since it is embedded in
> the MAC driver, there should not be a need.

I don't see a problem with doing that though, it may be extra
information, but if we ever have a standalone MDIO bus controller that
happens to be supported by the same HW/driver, and the Ethernet driver
delegates the MDIO management to this MDIO bus driver, then having the
compatible string is kind of mandatory for proper matching/identification.
-- 
Florian