netdev - Re: [PATCH net] tcp: Avoid preprocessor directives in tracepoint macro args

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171226.172556.476441061823840553.davem@davemloft.net>
Date:   Tue, 26 Dec 2017 17:25:56 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mathew.j.martineau@...ux.intel.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH net] tcp: Avoid preprocessor directives in tracepoint
 macro args

From: Mat Martineau <mathew.j.martineau@...ux.intel.com>
Date: Thu, 21 Dec 2017 10:29:09 -0800

> Using a preprocessor directive to check for CONFIG_IPV6 in the middle of
> a DECLARE_EVENT_CLASS macro's arg list causes sparse to report a series
> of errors:
> 
> ./include/trace/events/tcp.h:68:1: error: directive in argument list
> ./include/trace/events/tcp.h:75:1: error: directive in argument list
> ./include/trace/events/tcp.h:144:1: error: directive in argument list
> ./include/trace/events/tcp.h:151:1: error: directive in argument list
> ./include/trace/events/tcp.h:216:1: error: directive in argument list
> ./include/trace/events/tcp.h:223:1: error: directive in argument list
> ./include/trace/events/tcp.h:274:1: error: directive in argument list
> ./include/trace/events/tcp.h:281:1: error: directive in argument list
> 
> Once sparse finds an error, it stops printing warnings for the file it
> is checking. This masks any sparse warnings that would normally be
> reported for the core TCP code.
> 
> Instead, handle the preprocessor conditionals in a couple of auxiliary
> macros. This also has the benefit of reducing duplicate code.
> 
> Cc: David Ahern <dsahern@...il.com>
> Signed-off-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

Applied.