netdev - Re: [PATCH net] bnx2x: Improve reliability in case of nested PCI errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171227.121349.689207304027894541.davem@davemloft.net>
Date:   Wed, 27 Dec 2017 12:13:49 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     gpiccoli@...ux.vnet.ibm.com
Cc:     ariel.elior@...ium.com, everest-linux-l2@...ium.com,
        netdev@...r.kernel.org, gpiccoli@...tonmail.ch
Subject: Re: [PATCH net] bnx2x: Improve reliability in case of nested PCI
 errors

From: "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>
Date: Fri, 22 Dec 2017 13:01:39 -0200

> While in recovery process of PCI error (called EEH on PowerPC arch),
> another PCI transaction could be corrupted causing a situation of
> nested PCI errors. Also, this scenario could be reproduced with
> error injection mechanisms (for debug purposes).
> 
> We observe that in case of nested PCI errors, bnx2x might attempt to
> initialize its shmem and cause a kernel crash due to bad addresses
> read from MCP. Multiple different stack traces were observed depending
> on the point the second PCI error happens.
> 
> This patch avoids the crashes by:
> 
>  * failing PCI recovery in case of nested errors (since multiple
>  PCI errors in a row are not expected to lead to a functional
>  adapter anyway), and by,
> 
>  * preventing access to adapter FW when MCP is failed (we mark it as
>  failed when shmem cannot get initialized properly).
> 
> Reported-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@...ux.vnet.ibm.com>

Applied, thank you.