netdev - Re: [PATCH net v1 1/1] tipc: fix hanging poll() for stream sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171228.121610.1404170008079035024.davem@davemloft.net>
Date:   Thu, 28 Dec 2017 12:16:10 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     parthasarathy.bhuvaragan@...il.com
Cc:     netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
        jon.maloy@...csson.com
Subject: Re: [PATCH net v1 1/1] tipc: fix hanging poll() for stream sockets

From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...il.com>
Date: Thu, 28 Dec 2017 12:03:06 +0100

> In commit 42b531de17d2f6 ("tipc: Fix missing connection request
> handling"), we replaced unconditional wakeup() with condtional
> wakeup for clients with flags POLLIN | POLLRDNORM | POLLRDBAND.
> 
> This breaks the applications which do a connect followed by poll
> with POLLOUT flag. These applications are not woken when the
> connection is ESTABLISHED and hence sleep forever.
> 
> In this commit, we fix it by including the POLLOUT event for
> sockets in TIPC_CONNECTING state.
> 
> Fixes: 42b531de17d2f6 ("tipc: Fix missing connection request handling")
> Acked-by: Jon Maloy <jon.maloy@...csson.com>
> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...il.com>

Applied and queued up for -stable.