lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Dec 2017 06:16:51 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Antoine Tenart <antoine.tenart@...e-electrons.com>, Andrew Lunn <andrew@...n.ch> Cc: thomas.petazzoni@...e-electrons.com, ymarkman@...vell.com, jason@...edaemon.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux@...linux.org.uk, kishon@...com, nadavh@...vell.com, miquel.raynal@...e-electrons.com, gregory.clement@...e-electrons.com, stefanc@...vell.com, mw@...ihalf.com, davem@...emloft.net, linux-arm-kernel@...ts.infradead.org, sebastian.hesselbarth@...il.com Subject: Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum On 12/28/2017 02:06 AM, Antoine Tenart wrote: > Hi Andrew, > > On Thu, Dec 28, 2017 at 08:20:53AM +0100, Andrew Lunn wrote: >> On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: >>> This patch adds one more generic PHY mode to the phy_mode enum, to allow >>> configuring generic PHYs to the 2.5G SGMII mode by using the set_mode >>> callback. >>> >>> Signed-off-by: Antoine Tenart <antoine.tenart@...e-electrons.com> >>> --- >>> include/linux/phy/phy.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h >>> index 4f8423a948d5..70459a28f3a1 100644 >>> --- a/include/linux/phy/phy.h >>> +++ b/include/linux/phy/phy.h >>> @@ -28,6 +28,7 @@ enum phy_mode { >>> PHY_MODE_USB_DEVICE, >>> PHY_MODE_USB_OTG, >>> PHY_MODE_SGMII, >>> + PHY_MODE_SGMII_2_5G, >>> PHY_MODE_10GKR, >>> PHY_MODE_UFS_HS_A, >>> PHY_MODE_UFS_HS_B, >> >> There was a discussion maybe last month about adding 2.5G SGMII. I >> would prefer 2500SGMII. Putting the number first makes it uniform with >> the other defines, 1000BASEX, 25000BASEX, 10GKR. > > Good to know. I wasn't completely sure how to name this mode properly, > but I'm fine with PHY_MODE_2500SGMII. I'll update the patches and send a > v2 (without the dt part). And since you are respinning, please make sure you update phy_modes() in the same header file as well as Documentation/devicetree/bindings/net/ethernet.txt with the newly added PHY interface mode. -- Florian
Powered by blists - more mailing lists