netdev - Re: [PATCH iproute2] gre/tunnel: Print erspan_index using print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff2454a9-7e38-a76c-33b6-7b6d561a7733@gmail.com>
Date:   Thu, 28 Dec 2017 17:48:32 +0200
From:   Serhey Popovych <serhe.popovych@...il.com>
To:     William Tu <u9012063@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2] gre/tunnel: Print erspan_index using
 print_uint()


> Hi Serhey,

Hi William,

Yes, iproute2-next/net-next branch contains fix already: we probably do
not need proposed change. Sorry for noise.

I'm currently focused on bug fixing in stable which affects my work for
iproute2-next. All my future work will be based on iproute2-next as it
contains refactoring, optimization and cleanups, not fixes.

Sorry again and thanks for feedback.

> 
> On Thu, Dec 28, 2017 at 3:12 AM, Serhey Popovych
> <serhe.popovych@...il.com> wrote:
>> One is missing in JSON output because fprintf()
>> is used instead of print_uint().
>>
>> Signed-off-by: Serhey Popovych <serhe.popovych@...il.com>
>> ---
>>  ip/link_gre.c  |    3 ++-
>>  ip/link_gre6.c |    4 +++-
>>  2 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/ip/link_gre.c b/ip/link_gre.c
>> index 896bb19..1e331c8 100644
>> --- a/ip/link_gre.c
>> +++ b/ip/link_gre.c
>> @@ -476,7 +476,8 @@ static void gre_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
>>         if (tb[IFLA_GRE_ERSPAN_INDEX]) {
>>                 __u32 erspan_idx = rta_getattr_u32(tb[IFLA_GRE_ERSPAN_INDEX]);
>>
>> -               fprintf(f, "erspan_index %u ", erspan_idx);
>> +               print_uint(PRINT_ANY,
>> +                          "erspan_index", "erspan_index %u ", erspan_idx);
>>         }
>>
> 
> Did you pull the latest code from net-next branch?
> I think I already fix it.
> William
> 




Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)