netdev - Re: [PATCH net 3/3] eet: ena: invoke netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B0951795-C990-49ED-9972-CDEED0F160A6@amazon.com>
Date:   Fri, 29 Dec 2017 08:00:33 +0000
From:   "Belgazal, Netanel" <netanel@...zon.com>
To:     Jakub Kicinski <kubakici@...pl>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        "Machulsky, Zorik" <zorik@...zon.com>,
        "Matushevsky, Alexander" <matua@...zon.com>,
        "Bshara, Saeed" <saeedb@...zon.com>,
        "Wilson, Matt" <msw@...zon.com>,
        "Liguori, Anthony" <aliguori@...zon.com>,
        "Bshara, Nafea" <nafea@...zon.com>,
        "Schmeilin, Evgeny" <evgenys@...zon.com>,
        "Tzalik, Guy" <gtzalik@...zon.com>
Subject: Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after
 netdev registered

Yes, I mean in my driver.
netif_carrier_off() have no effect when netdev is uninitialized.
So I must call it after register_netdev().

On 12/29/17, 9:46 AM, "Jakub Kicinski" <kubakici@...pl> wrote:

    By "should" you mean in your driver, right?  I think calling
    netif_carrier_off() on an unregistered netdev is a pretty standard
    thing to do for drivers which manage carrier state.