netdev - Re: net-next lan9303 and CONFIG_NET_DSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ebd788f8-5ed7-d564-aa2c-8ab37a77480a@egil-hjelmeland.no>
Date:   Fri, 29 Dec 2017 16:45:19 +0100
From:   Egil Hjelmeland <privat@...l-hjelmeland.no>
To:     Florian Fainelli <f.fainelli@...il.com>, andrew@...n.ch,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: net-next lan9303 and CONFIG_NET_DSA_LEGACY

On 15. des. 2017 21:06, Florian Fainelli wrote:
> On December 15, 2017 6:51:45 AM PST, Egil Hjelmeland <privat@...l-hjelmeland.no> wrote:
>> Hi
>> I found that our lan9303 board is unable to receive network data unless
>>
>> CONFIG_NET_DSA_LEGACY is set. Is that a problem with the driver, or our
>>
>> Any advise would be appreciated.
> 
> Your DTS appears sane and using the new binding. Is the switch driver successfully probing and it is just packet transmission/reception that is non functional?
> Hi Egil,
> 

Hi Florian

I found that the problem is that !CONFIG_NET_DSA_LEGACY version of 
dsa_legacy_register() return -ENODEV;

That makes dsa_init_module() drop out before 
"dev_add_pack(&dsa_pack_type)", and we don't get any handler for ETH_P_XDSA.

Changed dsa_legacy_register to return 0, and it works.

Egil