netdev - Re: [PATCH] sky2: Replace mdelay with msleep in sky2_vpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171230091906.6eabcf39@xeon-e3>
Date:   Sat, 30 Dec 2017 09:19:06 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     mlindner@...vell.com, shemminger@...ux-foundation.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sky2: Replace mdelay with msleep in sky2_vpd_wait

On Sat, 30 Dec 2017 19:09:47 +0800
Jia-Ju Bai <baijiaju1990@...il.com> wrote:

> sky2_vpd_wait is not called in an interrupt handler nor holding a spinlock.
> The function mdelay in it can be replaced with msleep, to reduce busy wait.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>
> ---
>  drivers/net/ethernet/marvell/sky2.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
> index 9efe177..9fe8530 100644
> --- a/drivers/net/ethernet/marvell/sky2.c
> +++ b/drivers/net/ethernet/marvell/sky2.c
> @@ -4287,7 +4287,7 @@ static int sky2_vpd_wait(const struct sky2_hw *hw, int cap, u16 busy)
>  			dev_err(&hw->pdev->dev, "VPD cycle timed out\n");
>  			return -ETIMEDOUT;
>  		}
> -		mdelay(1);
> +		msleep(1);
>  	}
>  
>  	return 0;

When sky2 was written mdelay was equivalent to current msleep.

Acked-by: Stephen Hemminger <stephen@...workplumber.org>