netdev - Re: [PATCH ipsec] xfrm: fix rcu usage in xfrm_get_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171231160912.pwxpjui55ohj57hy@gauss3.secunet.de>
Date:   Sun, 31 Dec 2017 17:09:12 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
CC:     <netdev@...r.kernel.org>, <syzkaller-bugs@...glegroups.com>,
        <ilant@...lanox.com>,
        <syzbot+ca425f44816d749e8eb49755567a75ee48cf4a30@...kaller.appspotmail.com>
Subject: Re: [PATCH ipsec] xfrm: fix rcu usage in xfrm_get_type_offload

On Sun, Dec 31, 2017 at 04:18:56PM +0100, Sabrina Dubroca wrote:
> request_module can sleep, thus we cannot hold rcu_read_lock() while
> calling it. The function also jumps back and takes rcu_read_lock()
> again (in xfrm_state_get_afinfo()), resulting in an imbalance.
> 
> This codepath is triggered whenever a new offloaded state is created.
> 
> Fixes: ffdb5211da1c ("xfrm: Auto-load xfrm offload modules")
> Reported-by: syzbot+ca425f44816d749e8eb49755567a75ee48cf4a30@...kaller.appspotmail.com
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Patch applied, thanks a lot for the fix Sabrina!