netdev - Re: [PATCH] ip6_tunnel: disable dst caching if tunnel is dual-stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180102.123302.2222179447489662456.davem@davemloft.net>
Date:   Tue, 02 Jan 2018 12:33:02 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     elicooper@....com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] ip6_tunnel: disable dst caching if tunnel is dual-stack

From: Eli Cooper <elicooper@....com>
Date: Mon, 25 Dec 2017 10:43:49 +0800

> When an ip6_tunnel is in mode 'any', where the transport layer
> protocol can be either 4 or 41, dst_cache must be disabled.
> 
> This is because xfrm policies might apply to only one of the two
> protocols. Caching dst would cause xfrm policies for one protocol
> incorrectly used for the other.
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Eli Cooper <elicooper@....com>

Please do not CC: stable on networking changes, as per the netdev
FAQ I queue these up by hand.

> -	} else if (!(t->parms.flags &
> +	} else if (t->parms.proto != 0 && !(t->parms.flags &
>  		     (IP6_TNL_F_USE_ORIG_TCLASS | IP6_TNL_F_USE_ORIG_FWMARK))) {

When you adjust the indentation of an inner-expression, you must reindent the
subsequent lines that are also part of that inner-expression.

I've fixed up both of these issues and applied your patch, but please
take care of this yourself next time.

Thanks.