netdev - Re: [PATCH net] ip6_tunnel: allow ip6gre dev mtu to be set below 1280

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180102.123640.1005693862725388582.davem@davemloft.net>
Date:   Tue, 02 Jan 2018 12:36:40 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] ip6_tunnel: allow ip6gre dev mtu to be set below
 1280

From: Xin Long <lucien.xin@...il.com>
Date: Mon, 25 Dec 2017 14:45:12 +0800

> Commit 582442d6d5bc ("ipv6: Allow the MTU of ipip6 tunnel to be set
> below 1280") fixed a mtu setting issue. It works for ipip6 tunnel.
> 
> But ip6gre dev updates the mtu also with ip6_tnl_change_mtu. Since
> the inner packet over ip6gre can be ipv4 and it's mtu should also
> be allowed to set below 1280, the same issue also exists on ip6gre.
> 
> This patch is to fix it by simply changing to check if parms.proto
> is IPPROTO_IPV6 in ip6_tnl_change_mtu instead, to make ip6gre to
> go to 'else' branch.
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied.