netdev - Re: [patch net] mlxsw: spectrum_router: Fix NULL pointer deref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180102.123924.311531485776936517.davem@davemloft.net>
Date:   Tue, 02 Jan 2018 12:39:24 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, mlxsw@...lanox.com
Subject: Re: [patch net] mlxsw: spectrum_router: Fix NULL pointer deref

From: Jiri Pirko <jiri@...nulli.us>
Date: Mon, 25 Dec 2017 09:02:54 +0100

> Mon, Dec 25, 2017 at 08:57:35AM CET, jiri@...nulli.us wrote:
>>From: Ido Schimmel <idosch@...lanox.com>
>>
>>When we remove the neighbour associated with a nexthop we should always
>>refuse to write the nexthop to the adjacency table. Regardless if it is
>>already present in the table or not.
>>
>>Otherwise, we risk dereferencing the NULL pointer that was set instead
>>of the neighbour.
>>
>>Fixes: a7ff87acd995 ("mlxsw: spectrum_router: Implement next-hop routing")
>>Signed-off-by: Ido Schimmel <idosch@...lanox.com>
>>Reported-by: Alexander Petrovskiy <alexpe@...lanox.com>
>>Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> 
> Dave, could you please queue this up for 4.14.y together
> with "mlxsw: spectrum: Relax sanity checks during enslavement".

Both applied and queued up for -stable.