netdev - Re: [PATCH 1/2] ravb: kill redundant check in the probe() method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <097a0013-17fc-4b74-0993-a672349efe5f@cogentembedded.com>
Date:   Tue, 2 Jan 2018 13:09:52 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     netdev@...r.kernel.org,
        "open list:RENESAS ETHERNET DRIVERS" 
        <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH 1/2] ravb: kill redundant check in the probe() method

Hello!

On 12/31/2017 9:41 PM, Sergei Shtylyov wrote:

> Browsing thru the driver diassembly, I noticed that gcc was  able to

    Aw, it's disassembly!
    DaveM, is that worth reposting?

> figure  out  that the 'ndev' pointer is always non-NULL when calling
> free_netdev()  on the probe() method's  error path and  thus skip that
> redundant NULL check... gcc is smart, be like gcc! 
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
[...]

MBR, Sergei