netdev - Re: [PATCH] flex_can: Correct the checking for frame length in flexcan_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01a2ed6c-b0f7-4cef-6967-5210045e7d7e@hartkopp.net>
Date:   Tue, 2 Jan 2018 12:17:03 +0100
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     Luu An Phu <phu.luuan@....com>, wg@...ndegger.com,
        mkl@...gutronix.de
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        stefan-gabriel.mirea@....com
Subject: Re: [PATCH] flex_can: Correct the checking for frame length in
 flexcan_start_xmit()



On 01/02/2018 04:44 AM, Luu An Phu wrote:
> From: "phu.luuan" <phu.luuan@....com>
> 
> The flexcan_start_xmit() function compares the frame length with data register
> length to write frame content into data[0] and data[1] register. Data register
> length is 4 bytes and frame maximum length is 8 bytes.
> 
> Fix the check that compares frame length with 3. Because the register length
> is 4.
> 
> Signed-off-by: Luu An Phu <phu.luuan@....com>

Reviewed-by: Oliver Hartkopp <socketcan@...tkopp.net>

Thanks for this improvement!

Best regards,
Oliver

> ---
>   drivers/net/can/flexcan.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> index 0626dcf..760d2c0 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -526,7 +526,7 @@ static int flexcan_start_xmit(struct sk_buff *skb, struct net_device *dev)
>   		data = be32_to_cpup((__be32 *)&cf->data[0]);
>   		flexcan_write(data, &priv->tx_mb->data[0]);
>   	}
> -	if (cf->can_dlc > 3) {
> +	if (cf->can_dlc > 4) {
>   		data = be32_to_cpup((__be32 *)&cf->data[4]);
>   		flexcan_write(data, &priv->tx_mb->data[1]);
>   	}
>