netdev - Re: [PATCH net-next 4/7] net: phy: add paged phy register accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180102131426.GA15036@lunn.ch>
Date:   Tue, 2 Jan 2018 14:14:26 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King - ARM Linux <linux@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 4/7] net: phy: add paged phy register accessors

> I've decided to solve this by changing it to:
> 
> + * phy_restore_page() must always be called after this, irrespective
> + * of success or failure of this call.
> 
> iow, not explaining /why/.

Hi Russell

That is fine by my. A quick read of the code makes it clear why.

     Andrew