netdev - Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Jan 2018 08:52:38 -0500 (EST)
From:   Bob Peterson <rpeterso@...hat.com>
To:     Julia Lawall <Julia.Lawall@...6.fr>
Cc:     dri-devel@...ts.freedesktop.org, dev@...nvswitch.org,
        linux-s390@...r.kernel.org, linux-scsi@...r.kernel.org,
        dccp@...r.kernel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        cluster-devel@...hat.com,
        esc storagedev <esc.storagedev@...rosemi.com>,
        Namhyung Kim <namhyung@...nel.org>, linux-ext4@...r.kernel.org,
        Jiri Olsa <jolsa@...hat.com>,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org
Subject: Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

----- Original Message -----
| Drop newline at the end of a message string when the printing function adds
| a newline.

Hi Julia,

NACK.

As much as it's a pain when searching the source code for output strings,
this patch set goes against the accepted Linux coding style document. See:

https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings

Regards,

Bob Peterson